Add DES #490
Merged
Add DES #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanyaVolgushev
force-pushed
the
add-des-release
branch
2 times, most recently
from
66d00fc to
dbbf329
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
VanyaVolgushev
force-pushed
the
add-des-release
branch
2 times, most recently
from
578470b to
4edd689
Compare
alexandrsmirn
requested changes
Nov 19, 2024
ol-imorozko
requested changes
Nov 20, 2024
p-senichenkov
requested changes
Nov 21, 2024
ol-imorozko
requested changes
Nov 22, 2024
ol-imorozko
requested changes
Nov 22, 2024
VanyaVolgushev
force-pushed
the
add-des-release
branch
from
fdac96a to
a72e340
Compare
VanyaVolgushev
force-pushed
the
add-des-release
branch
from
85917ad to
339102d
Compare
ol-imorozko
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Oh, by the way, I feel like I left a comment somewhere that asks to change
std::vector a;
loop (x : vector b) {a.push_back(foo(x))}to
std::vector a(b.size());
loop (x : vector b) {a.push_back(foo(x))}instead of
std::vector a;
a.reserve(b.size());
loop (x : vector b) {a.push_back(foo(x))}which is, of course, wrong, but I don't remember where :)
ol-imorozko
requested changes
Dec 17, 2024
src/core/algorithms/nar/des/des.cpp
Outdated
| auto compare_by_fitness = [](EncodedNAR const& a, EncodedNAR const& b) { | ||
| return a.GetQualities().fitness > b.GetQualities().fitness; | ||
| }; | ||
| std::sort(population.begin(), population.end(), compare_by_fitness); |
There was a problem hiding this comment.
I don't see ranges in the updated version
| auto resulting_nar = model::NAR(); | ||
|
|
||
| std::vector<size_t> feature_order(encoded_value_ranges_.size()); | ||
| std::iota(std::begin(feature_order), std::end(feature_order), 0); |
There was a problem hiding this comment.
I don't see that in the updated version
|
LGTM apart from those last five requested changes |
ol-imorozko
approved these changes
Dec 22, 2024
p-senichenkov
approved these changes
Dec 23, 2024
alexandrsmirn
approved these changes
Dec 29, 2024
VanyaVolgushev
force-pushed
the
add-des-release
branch
from
7b0a428 to
322e218
Compare
chernishev
force-pushed
the
add-des-release
branch
from
322e218 to
1519a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add differential evolution solver algorithm for mining numerical association rules.