Add DES python bindings #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanyaVolgushev
force-pushed
the
add-des-bindings-release
branch
from
f909e81 to
951faac
Compare
VanyaVolgushev
force-pushed
the
add-des-bindings-release
branch
from
951faac to
3395d12
Compare
VanyaVolgushev
force-pushed
the
add-des-bindings-release
branch
2 times, most recently
from
637813d to
b93e464
Compare
BUYT-1
requested changes
Jan 10, 2025
VanyaVolgushev
force-pushed
the
add-des-bindings-release
branch
from
deb8a64 to
4494df5
Compare
xJoskiy
reviewed
Jan 16, 2025
Comment on lines
+48
to
+55
| auto const& GetAnte() const { | ||
| return ante_; | ||
| } | ||
|
|
||
| auto const& GetCons() const { | ||
| return cons_; | ||
| } | ||
|
|
There was a problem hiding this comment.
Also can be marked as noexcept
| #include "algorithms/nar/value_range.h" | ||
| #include "py_util/bind_primitive.h" | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
Why do you need an anonymous namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.