don't baaseline unreachable/unused/deprecated diagnostic levels as th…

…ey aren't errors
DetachHead · Aug 29, 2024 · 85487cf · 85487cf
1 parent b08c31a
commit 85487cf
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/packages/pyright-internal/src/baseline.ts b/packages/pyright-internal/src/baseline.ts
@@ -3,6 +3,7 @@ import { FileDiagnostics } from './common/diagnosticSink';
 import { Range } from './common/textRange';
 import { mkdirSync, readFileSync, writeFileSync } from 'fs';
 import { Uri } from './common/uri/uri';
+import { DiagnosticCategory } from './common/diagnostic';
 
 interface BaselineFile {
     files: {
@@ -28,10 +29,19 @@ export const diagnosticsToBaseline = (rootDir: Uri, filesWithDiagnostics: FileDi
             baselineData.files[filePath] = [];
         }
         baselineData.files[filePath].push(
-            ...fileWithDiagnostics.diagnostics.map((diagnostic) => ({
-                code: diagnostic.getRule() as DiagnosticRule | undefined,
-                range: diagnostic.range,
-            }))
+            ...fileWithDiagnostics.diagnostics
+                .filter(
+                    (diagnostic) =>
+                        ![
+                            DiagnosticCategory.Deprecated,
+                            DiagnosticCategory.UnreachableCode,
+                            DiagnosticCategory.UnusedCode,
+                        ].includes(diagnostic.category)
+                )
+                .map((diagnostic) => ({
+                    code: diagnostic.getRule() as DiagnosticRule | undefined,
+                    range: diagnostic.range,
+                }))
         );
     }
     return baselineData;