Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bun instead of node #202

Closed
wants to merge 5 commits into from
Closed

use bun instead of node #202

wants to merge 5 commits into from

Conversation

DetachHead
Copy link
Owner

@DetachHead DetachHead commented Mar 25, 2024

fixes #60

potentially also fixes these issues - need to confirm with the people who raised them:

@divaltor
Copy link

There are any performance benchmarks for that replacement?

@DetachHead
Copy link
Owner Author

i measured how long it took to run pyright 100 times with both node and bun and it was only a few seconds faster lol. the main reason i wanted to try this was to see if it would fix any of the issues people had with the bundled node, but tbh it will probably cause more problems than it'll solve. can't even get bun install to work

@divaltor
Copy link

Few seconds still is nice. Would be nice to see more detailed benchmark with hyperfine or similar tool. Good job

@DetachHead
Copy link
Owner Author

all of the issues mentioned in the OP have been resolved (except #177 which is just pending some documentation), so i don't really see much point in doing this anymore, especially since there was pretty much no performance gains. can re-visit in the future if that changes

@DetachHead DetachHead closed this Jun 18, 2024
@DetachHead DetachHead mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate bun
2 participants