Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from nodejs-bin to nodejs-wheel #323

Merged
merged 7 commits into from
May 8, 2024

Conversation

lewis6991
Copy link
Contributor

@lewis6991 lewis6991 commented Apr 25, 2024

Wider support for older glibc

Fixes #167


I'm not super familiar with the project, so fixed up what I could. Let me know what I've missed.

Copy link
Owner

@DetachHead DetachHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pyproject.toml Outdated Show resolved Hide resolved
basedpyright/run_node.py Outdated Show resolved Hide resolved
pdm_build.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved

This comment has been minimized.

@DetachHead DetachHead force-pushed the nodejs-wheel branch 2 times, most recently from 8430ce8 to 9435e4a Compare April 25, 2024 15:47

This comment has been minimized.

3 similar comments

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@njzjz
Copy link

njzjz commented May 3, 2024

Hi, Node v20.13.0 is planned to be released on 2024-05-07 (nodejs/node#52793). I will release nodejs-wheel on the same day.

@DetachHead DetachHead merged commit 7f8755f into DetachHead:main May 8, 2024
8 checks passed
@lewis6991 lewis6991 deleted the nodejs-wheel branch May 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid glibc versions.
3 participants