Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't unmount the Nix store when doing a curing reinstall, plus other nits and cleanup #1299

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Don't unmount the Nix store when doing a curing reinstall, plus other nits and cleanup #1299

merged 9 commits into from
Nov 19, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 19, 2024

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Nov 19, 2024
@grahamc grahamc enabled auto-merge (squash) November 19, 2024 17:35
@grahamc grahamc merged commit 490f48d into main Nov 19, 2024
21 checks passed
@grahamc grahamc deleted the reup-nits branch November 19, 2024 17:46
@cole-h cole-h added this to the 0.29.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @cole-h