Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Panaromic Camera Angle. Fixes #140 #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ritankarsaha
Copy link
Contributor

Description

This PR fixes the issue #140 raised by me - Ritankar Saha thereby successfully integrating a new camera angle - Panaromic Camera Angle to the Project.

Fixes: #140

Type of change

  • [ x] New feature (non-breaking change which adds functionality)

Checklist:

  • [ x] I have made this from my own
  • [x ] I have taken help from some online resourses
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
Screenshot 2024-05-24 at 1 49 46 AM

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@ritankarsaha
Copy link
Contributor Author

I have fixed the issue #140 opened by me thereby adding a new camera angle - Panaromic Camera Angle to the project and also raised a PR for the same #170

@Dev-tanay
Copy link
Owner

Please attach a video of your changes @ritankarsaha

@ritankarsaha
Copy link
Contributor Author

@Dev-tanay I am sorry but i have rebased the codebase on my desktop with the main branch, rendering it's changes as the PR was 2 weeks old and i thought the repo went dead.
I don't have the codebase on my desktop now owing to it getting rebased with the main branch. I ensure you all the changes are rendered correctly, I have previously worked on this codebase as well fixing 2 issues handling authentication measures. Please review the code, the changes are quite clear and have been commented as well for better understanding.
Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding A New Camera Angle to the Project
2 participants