Complaints suggestions #49

preetamozarde3 · 2019-02-07T19:36:42Z

The following changes have been made in this branch:

A complaint/suggestions module has been added to the app.
A complaint/suggestions tab has been added in the navigation bar, on the clicking of which the user is taken to the complaints home page.
On this page, the user can:
- View all the complaints posted in the app.
- Up vote a complaint if they are in support of it.
- Subscribe to a particular complaint.
- Navigate to the complaint details page to view the details of a particular complaint by clicking on the complaint card.
- Navigate to the file complaints page to post a new complaint by clicking on the 'Vent your issues' button at the top of the page.
The file complaints page allows the user to file a new complaint. They can add the following information along with the description to give a more complete account of their issue:
- Images, suggestions, location details and tags
The complaint details page has the following features:
- The users can view the description, suggestions and location details added by the creator.
- The users can view the images and tags (if any) associated with the complaint.
- The users can comment, up vote or subscribe to the complaint if the wish.
All the components along with the associated HTML and CSS files for the aforementioned three pages have been added to a new folder named venter.
Apart from these additions, additions have been made to the nav menu, data service, interfaces, API and assets.

… dependencies

pulsejet · 2019-02-08T13:08:25Z

@preetamozarde3 check my review on #47; I had left 40 odd comments on it that'll need to be fixed.

pulsejet

I haven't tested this yet; but I'll try to do that in the next couple of days. In the meanwhile, other than the mostly minor issues I've pointed out below, you might want to make sure the design is responsive. Particularly, it should work on the following screen sizes (these are the sizes and browsers the rest of the app is being tested on):

4.7 inch phone (iPhone)
5.5+ inch phones (general android phones)
10 inch tablet (iPad, say)
14+ inch laptops

and must have browser compatibility for

Firefox (Desktop)
Chrome (Desktop)
Edge (Desktop)
Chrome (Android)
Safari (iOS)
IE 11 (best effort)

In general, you shouldn't have issues with JS compatibilty unless you're using some funky ES7 which you might need to polyfill, but CSS behavior can differ seriously between desktop browsers (which are somewhat consistent), Chrome for Android and iOS Safari.

Also, you could take cues from the rest of the app if you're unsure how this is supposed to look in responsive mode. In general, the screen is divided into three parts for desktop and tablet, with the navmenu at the left, a list or editing area at center and detailed information to the right. There are reusable components to make such a layout. More specifically, check the feed, calendar, add-event and update-body components' layouts.

pulsejet · 2019-02-19T12:14:48Z

src/app/app.module.ts

@@ -100,6 +112,7 @@ import { CardComponent } from './card/card.component';
    HttpClientModule,
    FormsModule,
    BrowserAnimationsModule,
+    MyMaterialClass,


This is already imported on line 157

pulsejet · 2019-02-19T12:15:26Z

src/app/app.module.ts

@@ -120,7 +133,6 @@ import { CardComponent } from './card/card.component';
      { path: 'quick-links', component: QuickLinksComponent, data: { state: 'base' } },
      { path: 'settings', component: SettingsComponent, data: { state: 'base' } },
      { path: 'about', component: AboutComponent, data: { state: 'overlay' } },
-


This whitespace was intentional

pulsejet · 2019-02-19T12:18:08Z

src/assets/placeholder_image.svg

+<g>
+	<path d="M0,48v416h512V48H0z M480,432H32V80h448V432z M352,160c0,26.51,21.49,48,48,48s48-21.49,48-48s-21.49-48-48-48
+		S352,133.49,352,160z M448,400H64l96-256l128,160l64-48L448,400z"/>
+</g>


Use add_image_placeholder.svg (which already exists in assets) instead of adding a new file

pulsejet · 2019-02-19T12:19:27Z

src/app/app.module.ts

  ],
  providers: [
    DataService,
    { provide: RouteReuseStrategy, useClass: CustomReuseStrategy },
    LoginActivate,
+    VenterDataService,


Move this just below DataService

pulsejet · 2019-02-19T12:21:12Z

src/app/interfaces.ts

+
+export interface IPostComment {
+    text: string;
+}


You don't need separate interfaces for posting. Reuse IComplaintComment.

pulsejet · 2019-02-19T12:34:18Z

src/app/venter/venter-data.service.ts

+  subscribeToComplaint(complaint_subscribed: number, complaintId: string) {
+    this.dataService.FireGET<IComplaint>(API.SubscribeToComplaint,
+        { complaintId: complaintId, action: complaint_subscribed === 0 ? 1 : 0 }).subscribe(result => {
+          console.log(result);


No logging to console please.

pulsejet · 2019-02-19T12:34:44Z

src/app/venter/venter-data.service.ts

+    } else if (complaint.status.toLowerCase() === 'resolved') {
+      complaint.status_color = 'green';
+    } else if (complaint.status.toLowerCase() === 'in progress') {
+      complaint.status_color = 'yellow';


Use switch...case here

pulsejet · 2019-02-19T12:36:10Z

src/app/venter/file-complaint/file-complaint.component.ts

+    if (this.complaint.description === '') {
+      this.venterDataService.getSnackbar('Please enter a description before submitting the complaint!', null);
+    } else {
+    this.dataService.FirePOST<IComplaint>(API.Complaints, this.complaint).subscribe(() => {});


pulsejet · 2019-02-19T12:38:34Z

src/app/venter/detailed-complaint/detailed-complaint.component.ts

+    this.editedComment = {} as IPostComment;
+    /* Get profile if the user is logged in */
+    if (this.dataService.isLoggedIn()) {
+      this.getUser();


This is still being treated as sync.

Just looked through this carefully; if I'm right that userid isn't being used anywhere besides checking if the comment was made by the user, you could let this be the way it is and explicitly initialize userid to null to be sure

pulsejet · 2019-02-19T12:41:52Z

src/app/venter/complaints-home/complaints-home.component.ts

+})
+export class ComplaintsHomeComponent implements OnInit {
+
+  public complaints = {} as IComplaint[];


You're basically casting a JSON object to an array here, which works cause the way JS is, but this is terribly confusing. In general, it's better to initialize everything as null (i.e. no initialization, just specify the type) and then put *ngIfs to check if data has been loaded async.

I tried that but I keep getting a TypeError (Cannot find property '...' of undefined)

That means you're trying to access some member for the variable before it is initialized (probably a misplaced ngIf). Before accessing anything in the variable, you need to check if it isn't null, easiest way to do which is add a *ngIf="complaints" to the container in which it is being accessed.

pulsejet · 2019-02-19T13:01:01Z

src/app/venter/detailed-complaint/detailed-complaint.component.html

+                    mat-icon-button>
+                    <mat-icon>delete</mat-icon>
+                </button>
+                <button *ngIf="complaintComment.commented_by.id==userid" 


=== not ==

pulsejet · 2019-02-19T13:03:53Z

src/app/venter/complaints-home/complaints-home.component.ts

+
+  public complaints = {} as IComplaint[];
+  public myComplaints = {} as IComplaint[];
+  public userid: string;


Where is userid being used in this component?

pulsejet · 2020-05-01T10:33:28Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 140

See the complete overview on Codacy

pulsejet · 2020-05-01T10:33:28Z

src/app/venter/complaint/detailed-complaint.component.css

+
+.complaint-tag {
+    padding: 1% 0;
+    background-color: yellowgreen


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:29Z

src/app/venter/complaint-card/complaint-card.component.css

+}
+
+.complaint-upvote-active {
+    color: #536dfe;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:30Z

src/app/venter/complaint-card/complaint-card.component.css

+    color: white;
+    padding: 0 2.5%;
+    font-weight: bold;
+    text-transform: uppercase;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:31Z

src/app/venter/complaint/detailed-complaint.component.css

+
+.display-image {
+    max-height: 400px;
+    max-width: 400px;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:33Z

src/app/interfaces.ts

+    id: string;
+    time: string;
+    text: string;
+    commented_by: IUserProfile;


Issue found: Identifier 'commented_by' is not in camel case.

pulsejet · 2020-05-01T10:33:34Z

src/app/venter/complaint-card/complaint-card.component.css

+
+.footer {
+    position: relative;
+    text-align: center;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:35Z

src/app/venter/complaint-card/complaint-card.component.css

+}
+
+.complaint-location-details {
+    padding-top: 2%;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:35Z

src/app/venter/complaints/complaints-home.component.css

+
+.complaint-button {
+    color: black;
+    background-color: yellow;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:37Z

src/app/venter/file/file-complaint.component.css

+  font-size: 18px;
+  border-radius: 0 3px 3px 0;
+  user-select: none;
+  background-color: rgba(0,0,0,0.8);


Issue found: Expected single space after "," in a single-line function (function-comma-space-after)

pulsejet · 2020-05-01T10:33:37Z

src/app/venter/complaints/complaints-home.component.css

+
+.toolbar {
+    padding: 150px 0;
+    background-color: #536dfe;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:38Z

src/app/interfaces.ts

@@ -162,6 +162,52 @@ export interface IUserTagCategory {
    tags: IUserTag[];
 }

+export interface IComplaintTag {
+    id: string;
+    tag_uri: string;


Issue found: Identifier 'tag_uri' is not in camel case.

pulsejet · 2020-05-01T10:33:39Z

src/app/venter/complaint/detailed-complaint.component.css

+
+.active,
+.dot:hover {
+    background-color: #717171;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:40Z

src/app/venter/complaint/detailed-complaint.component.css

+/* The dots/bullets/indicators */
+
+.dot {
+    cursor: pointer;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:41Z

src/app/venter/complaint/detailed-complaint.component.css

+
+.dot {
+    cursor: pointer;
+    height: 15px;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:42Z

src/app/venter/complaint/detailed-complaint.component.css

+    color: black;
+    background-color: yellow;
+    padding: 10px 50px;
+    font-weight: bold;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:43Z

src/app/venter/complaints/complaints-home.component.css

+}
+
+.no-complaints-image {
+    width: 50%;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:44Z

src/app/venter/file/file-complaint.component.css

+  * {box-sizing: border-box}
+    body {margin:0}
+    .mySlides {display: none;}
+    img {vertical-align: middle; height: 20%;}


Issue found: Expected single space after "{" of a single-line block (block-opening-brace-space-after)

pulsejet · 2020-05-01T10:33:45Z

src/app/venter/file/file-complaint.component.css

+  * {box-sizing: border-box}
+    body {margin:0}
+    .mySlides {display: none;}
+    img {vertical-align: middle; height: 20%;}


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:46Z

src/app/venter/complaint-card/complaint-card.component.css

+.status {
+    float: right;
+    background-color: red;
+    border-width: medium;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:47Z

src/app/interfaces.ts

+
+export interface IComplaint {
+    id: string;
+    created_by: IUserProfile;


Issue found: Identifier 'created_by' is not in camel case.

pulsejet · 2020-05-01T10:33:48Z

src/api.ts

-    UserTagsReach: 'api/user-tags/reach'
+    UserTagsReach: 'api/user-tags/reach',
+
+    Complaints: 'api/venter/complaints',


Issue found: Strings must use doublequote.

pulsejet · 2020-05-01T10:33:49Z

src/app/venter/complaint/detailed-complaint.component.css

+    margin: 0 2px;
+    background-color: #bbb;
+    border-radius: 50%;
+    display: inline-block;


Issue found: Expected indentation of 2 spaces (indentation)

pulsejet · 2020-05-01T10:33:50Z

src/app/interfaces.ts

+    users_up_voted: IUserProfile[];
+    images: string[];
+    comments: IComplaintComment[];
+    vote_count: number;


Issue found: Identifier 'vote_count' is not in camel case.

pulsejet · 2020-05-01T10:33:51Z

src/app/venter/file/file-complaint.component.css

+
+* {box-sizing: border-box}
+body {margin:0}
+.mySlides {display: none; padding-right: 5%;}


Issue found: Expected no more than 1 declaration (declaration-block-single-line-max-declarations)

pulsejet · 2020-05-01T10:33:52Z

src/app/interfaces.ts

+    report_date: string;
+    reported_date: string;
+    status: string;
+    status_color: string;


Issue found: Identifier 'status_color' is not in camel case.

preetamozarde3 added 9 commits February 6, 2019 12:17

Added a complaints/suggestions module

bc78eef

Pull changes from the master to make it upto date with feature branch

d0ab16a

Minor Codacy Changes

9ce0d43

Make minor codacy changes

805109f

Make minor codacy adjustments

a8e5d0c

Add feature to open user profile on click of a card and remove unused…

bd50c25

… dependencies

Fix merge conflicts

d3873d0

Sync package.json and package-lock.json

f0b5e51

Fix minor lint errors

d94fdfb

preetamozarde3 added 8 commits February 18, 2019 21:14

Changes to module and addition of more features

825dbbc

Pull from master and merge changes

58db2e8

Pull from master and merge changes

60aec58

Add edit component css file

ef3e8c6

Fix merge conflicts

ab90d2b

Fix merge conflicts

e5fb7d1

Revert changes to package-lock.json file

fa6d142

Revert deletion of launch.json file

659389a

pulsejet reviewed Feb 19, 2019

View reviewed changes

preetamozarde3 added 3 commits February 20, 2019 19:33

Make required changes

bc6f9f9

Fix merge conflicts

076a2df

Fix build error

f061836

pulsejet reviewed May 1, 2020

View reviewed changes

Complaints suggestions #49

Are you sure you want to change the base?

Complaints suggestions #49

Conversation

preetamozarde3 commented Feb 7, 2019

pulsejet commented Feb 8, 2019

pulsejet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulsejet commented May 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment