Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint #521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: fix lint #521

wants to merge 2 commits into from

Conversation

pulsejet
Copy link
Collaborator

@pulsejet pulsejet commented Mar 17, 2024

Some comments for whoever (if anyone) is maintaining this

  • VS Code has a flake8 extension that shows lint errors inline
  • Commented-out code should never be checked in
  • Docstrings go after the function declaration
  • Docstrings are NOT multiline comments (please)
  • Not sure why adj_list.py is ... .py
  • eval is (extremely) evil

@pulsejet pulsejet requested review from VIBR0X and srbh001 March 17, 2024 22:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 91.59%. Comparing base (ebf357c) to head (b8b1f7d).

Files Patch % Lines
bans/views.py 28.57% 5 Missing ⚠️
locations/views.py 50.00% 5 Missing ⚠️
roles/helpers.py 54.54% 5 Missing ⚠️
buyandsell/views.py 60.00% 4 Missing ⚠️
lostandfound/models.py 0.00% 3 Missing ⚠️
community/views.py 50.00% 1 Missing ⚠️
lostandfound/views.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   91.53%   91.59%   +0.06%     
==========================================
  Files         157      157              
  Lines        6580     6571       -9     
==========================================
- Hits         6023     6019       -4     
+ Misses        557      552       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsejet pulsejet changed the title chore: fix lint WIP: chore: fix lint Mar 17, 2024
@pulsejet pulsejet changed the title WIP: chore: fix lint chore: fix lint Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants