Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove peer dependencies #696

Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix: remove peer dependencies #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd3db0c
remove peer dependencies
ajwootto Jan 17, 2024
c41678a
remove
ajwootto Jan 17, 2024
f151308
lock
ajwootto Jan 17, 2024
b956292
prettier
ajwootto Jan 17, 2024
53497ed
remove lint fix
ajwootto Jan 17, 2024
26be823
fix lint
ajwootto Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"scripts": {
"lint": "nx run-many --parallel --target lint --all",
"test": "nx run-many --parallel --target test --all",
"affected:lint": "nx affected --base=origin/main --head=HEAD --target=lint --fix",
"affected:lint": "nx affected --base=origin/main --head=HEAD --target=lint",
"affected:test": "nx affected --base=origin/main --head=HEAD --target=test",
"affected:e2e": "nx affected --base=origin/main --head=HEAD --target=e2e",
"npm-publish": "nx affected --base=origin/main~1 --target=npm-publish",
Expand Down
7 changes: 6 additions & 1 deletion sdk/nextjs/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"files": ["*.json"],
"parser": "jsonc-eslint-parser",
"rules": {
"@nx/dependency-checks": ["error"]
"@nx/dependency-checks": [
"error",
{
"ignoredDependencies": ["next", "react"]
}
]
}
},
{
Expand Down
8 changes: 2 additions & 6 deletions sdk/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@
"hoist-non-react-statics": "^3.3.2",
"server-only": "^0.0.1"
},
"peerDependencies": {
"next": ">=14.0.0",
"react": "^18.2.0"
},
"types": "./src/index.d.ts",
"exports": {
".": {
"import": "./index.js",
Expand All @@ -29,6 +26,5 @@
"require": "./pages.js",
"types": "./pages.d.ts"
}
},
"types": "./src/index.d.ts"
}
}
7 changes: 6 additions & 1 deletion sdk/openfeature-nodejs-provider/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
"files": ["*.json"],
"parser": "jsonc-eslint-parser",
"rules": {
"@nx/dependency-checks": "error"
"@nx/dependency-checks": [
"error",
{
"ignoredDependencies": ["@openfeature/core"]
}
]
}
},
{
Expand Down
3 changes: 0 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5181,9 +5181,6 @@ __metadata:
"@devcycle/types": ^1.4.6
hoist-non-react-statics: ^3.3.2
server-only: ^0.0.1
peerDependencies:
next: ">=14.0.0"
react: ^18.2.0
languageName: unknown
linkType: soft

Expand Down
Loading