feat: add IfEnabled helper #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
jsalaber
reviewed
Jan 24, 2024
sdk/nextjs/src/client/IfEnabled.tsx
Outdated
| import useVariableValue from './useVariableValue' | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types | ||
| export const ifEnabled = <T extends { default: ComponentType<any> }>( |
There was a problem hiding this comment.
is there a better name than ifEnabled, maybe renderIfEnabled?
| @@ -6,6 +6,7 @@ import { getUserAgent } from './userAgent' | |||
| import { getAllVariables } from './getAllVariables' | |||
| import { getAllFeatures } from './allFeatures' | |||
| import { DevCycleNextOptions } from '../common/types' | |||
| import { ComponentProps, ComponentType, lazy } from 'react' | |||
There was a problem hiding this comment.
are these used? can they be cleaned up?
jsalaber
approved these changes
Jan 24, 2024
jonathannorris
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper for dynamically importing components into the client bundle depending on feature flag values.
It's used like this:
The result is that if the flag evaluates to false, the component code is never sent to the client.
If it evaluates to true, the initial rendered content is send by the server and the component is "progressively enhanced" with the interactive JS after the page loads (lazy loaded)