Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vercel Edge Config Adapter #896

Merged
merged 9 commits into from
Jul 22, 2024
Merged

feat: Vercel Edge Config Adapter #896

merged 9 commits into from
Jul 22, 2024

Conversation

ajwootto
Copy link
Contributor

@ajwootto ajwootto commented Jul 17, 2024

  • create package for retrieving configs from Vercel Edge Config on Node.js
  • refactor config manager to accept a generic "storage provider" so the source of the config can be swapped

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 7:03pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 7:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Jul 19, 2024 7:03pm

@@ -0,0 +1,14 @@
{
"name": "devcycle-js-sdks",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is file this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a file that nx keeps automatically adding every time you generate a new package. I was thinking of just giving up and letting it be generated...

@ajwootto ajwootto merged commit 11aa09c into main Jul 22, 2024
12 checks passed
@ajwootto ajwootto deleted the verrcel-edge-config branch July 22, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants