Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: js-sdk was improperly setting isIntialized to true even for situations where the SDK token was invalid #918

Merged
merged 9 commits into from
Aug 14, 2024
Merged

fix: js-sdk was improperly setting isIntialized to true even for situations where the SDK token was invalid #918

merged 9 commits into from
Aug 14, 2024

Conversation

kaushalkapasi
Copy link
Contributor

@kaushalkapasi kaushalkapasi commented Aug 7, 2024 •
edited
Loading

Reference: #913

  • fix: adds initialization validation to ensure the SDK key provide to the JS SDK starts with dvc_client or client
    • fix: allows server key to be used when initializing the JS Client SDK from the NextJS SDK
  • fix: calls the reject handler for on Initialized if the Client SDK API rejects the SDK token with a 401 - Forbidden error message

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:45pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Aug 14, 2024 7:45pm

@kaushalkapasi kaushalkapasi requested a review from jsalaber August 7, 2024 18:26
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from 4014622 to 55f1355 Compare August 7, 2024 19:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
sdk/js/__tests__/Client.spec.js Dismissed Show dismissed Hide dismissed
sdk/js/__tests__/index.spec.js Fixed Show fixed Hide fixed
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from 55f1355 to 4d9791e Compare August 7, 2024 20:08
ajwootto
ajwootto reviewed Aug 7, 2024
View reviewed changes
sdk/js/src/index.ts Outdated Show resolved Hide resolved
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from ade45ec to 900a71a Compare August 7, 2024 20:17
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from ef28b9c to f9aa976 Compare August 7, 2024 21:25
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from f9aa976 to 1182e4a Compare August 7, 2024 21:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
sdk/js/__tests__/index.spec.js Dismissed Show dismissed Hide dismissed
@kaushalkapasi kaushalkapasi requested a review from ajwootto August 8, 2024 15:58
ajwootto
ajwootto reviewed Aug 14, 2024
View reviewed changes
sdk/js/src/Request.ts Outdated Show resolved Hide resolved
@kaushalkapasi kaushalkapasi requested a review from ajwootto August 14, 2024 15:17
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from fc52bc6 to 2bfc77a Compare August 14, 2024 15:28
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from 2bfc77a to 0d726f4 Compare August 14, 2024 18:21
@kaushalkapasi
fix: adds SDK Key format validation for JS SDK to make sure key start…
52676cf 
…s with client or dvc_client
@kaushalkapasi
fix: update invalid sdk key error message
1483a55
@kaushalkapasi
fix: reject onIntialize promise when the API returns a 401 or 403 due…
dec9d51 
… to an invalid Client SDK Key
@kaushalkapasi
fix: allow other key formats when the js-client-sdk is intialized fro…
d0679c8 
…m the nextjs sdk
@kaushalkapasi
chore: adds UserError utility class to allow for cleaner error handli…
dc23360 
…ng and reporting
@kaushalkapasi
chore: remove gitstream. update upload-artifact gh action to use v4
4d4e0ad
@kaushalkapasi
fix: remove error stack override from UserError class in js-sdk
8143a48
@kaushalkapasi
fix: update getConfigJson error handling to only throw e.message cont…
1bcd6a7 
…ents if the error is an instance of ResponseError
@kaushalkapasi
chore: remove custom UserError class from js-client-sdk utils and use…
c952b5c 
… the one from shared devcycle/types
@kaushalkapasi kaushalkapasi force-pushed the fix-js-sdk-improperly-settings-intialized branch from 0d726f4 to c952b5c Compare August 14, 2024 19:27
@kaushalkapasi kaushalkapasi requested a review from ajwootto August 14, 2024 19:27
@kaushalkapasi kaushalkapasi enabled auto-merge (squash) August 14, 2024 19:28
@kaushalkapasi kaushalkapasi merged commit 4462e6d into main Aug 14, 2024
12 checks passed
@kaushalkapasi kaushalkapasi deleted the fix-js-sdk-improperly-settings-intialized branch August 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwootto ajwootto ajwootto approved these changes

@elliotCamblor elliotCamblor Awaiting requested review from elliotCamblor

@jsalaber jsalaber Awaiting requested review from jsalaber

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushalkapasi @ajwootto