Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: add Custom keyboard navigation topic #5573
DataGrid: add Custom keyboard navigation topic #5573
Changes from 1 commit
b5d5631
f080a34
b408ee8
45b023c
4cf380b
b168438
67236f0
3407993
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. What connection the mentioned getCellElement method has with the focus movement scenario we describe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You call getCellElement to get a cell container so you can then call focus.
Like
const cell = e.getCellElement(); focus(cell);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a mandatory or optional step? If it's optional, then this wording is probably fine as it is. Otherwise, we should state that one should call the mentioned methods in conjunction in order to achieve the desired result.
From what I gather, judging from your example, this is a mandatory step. Therefore, you first obtain this object/entity named "cell" whatever it is -- and then you pass it to the
focus
method as a parameter. Shouldn't we explain things here exactly as they are?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this part