-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/email verification flow completed #233
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://academy-turbo-git-feat-emailverification-v2-developdao.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Markkos89
At what stage of the user journey do I set up, or log in with an email? And what triggers the modal to open, and approximately how long do I have to wait for it to open? E.g. 2 scenarios when I click Academy's "CONNECT" button
-
when l log in with my piablo.eth address (used many times and done quizzes on Academy) I just sign in with my wallet and I am not prompted to do anything else. I remember waiting for a lot of seconds and nothing happened -
when I go to log in on an incognito browser tab, the first prompt I get is to log in with a wallet. I didn't go further and create a new wallet. Is that the intended next step, i.e. log in with wallet, then get your new modal's prompts to connect my wallet with an email address?
update
- when I went back to Academy for something else (the browser tab was still open), the email modal prompt was open on the page on my piablo.eth Brave profile (my wallet was NOT connected). I can't say how long it takes for the modal to be activated.
Let me know if this makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for shipping this PR quickly !
Copying in the stories we agreed on the notion doc:
- As a business, we need to validate emails for all accounts to ensure some sybil resistance before users are able to complete any quizes/lessons
- As a business, we need to be able to mass emails users (via SendGrid)
- As a user, I need to associate an my email to my account and validate it
- As a user, I want to get email updates on new courses (mass manual emails via Sendgrid)
- As a user, I can’t complete a lesson/quiz without an account and validated email
The model is looking great, good work!
Here is how I experienced the feature:
- Click preview link to load web page
- Modal immediately came up when web page was loaded even though I was not singed-in.
- Filled out the modal and did not receive an email
- Modal no longer shows up
Let me know if I'm missing something here though to associate the email with an account I expect to need to be logged into my account first. I was unable to test the verification as I did not receive the an email from sendgrind.
The flow we're looking for is:
- Users signs-up/in
- Modal pops up and they fill in their email
- User gets email and comes back to site to confirm email
- User now fully verified
- User is only able to complete quizzes and log these in the DB once they have an account with a verified email, if they don't have an account with a verified email, the button should show "sign-up" or "validate your email". If "validate your email? is shown, it should open the modal when clicked.
Does that make sense? I booked a call in your diary this evening in case it's helpful for us to speak as it's the only time I have free, and I'm out most of the day. If we can tackle this async then awesome too :)
…ting code, and more
Hello guys! Thanks a millon for both inputs! Let me know what do you think about the flow or anything. Open to suggestions/ideas. Next steps would be to mutate the emailVerifed field with the verification Date with a mutation I have to built and that would be it. Thank you so much!! 🙌 @elPiablo @kempsterrrr @wolovim 🚀 |
@Markkos89 opened issue re privacy policy as discussed - #234 |
The email validation flow is completed now! With email with verification being sent, verification of the number, and everything stored in database. cc: @wolovim @elPiablo @kempsterrrr please check it and let's ship it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEy @Markkos89
Just want to show what the basic user flow is.
Here are two scenarios I've tested:
Number 1:
-
I have a brand new browser profile, with a brand new wallet, and I will be using a new email address
-
I open: https://academy-turbo-ktaoi4yeb-developdao.vercel.app/ on that profile and nothing happens.
-
So I click on Academy's CONNECT button => wallet opens, I click on 'Connect' in the wallet => "Verify your Account"/Send message => Sign in and =>
-
I get your modal to "Configrure your email".
-
I fill in email in modal, but i don't get an email notification (also not in spam/junk)
-
therefore I can't "Insert the verification Code Sent"
Number 2:
- I open a well used browser profile, i.e. my 'daily' Brave profile, which has my 'piablo.eth' wallet (I've done loads of quizzes, etc with this wallet) with the URL: https://academy-turbo-ktaoi4yeb-developdao.vercel.app/
- Nothing happens, so I do the same as above, log into my piablo.eth wallet and sign on to Academy.
- Important to note, I haven't coupled/paired this wallet to an email address on Academy, but the modal appears asking me to "Insert the verification code Sent"
Can you give some bullet points on 2 or 3 scenarios of the user please? (
- a brand new user
- and a user who has a wallet and email successfully coupled to each other
- and a user such as me, where my wallet is recognised in the database, but I don't have an email yet address attached to it (maybe I'm wasting your time with this 3rd option, and it's not relevant for us all)
Hey Piablo! GM! Let's check:
you already have email's set up: So, @elPiablo are you NOT receiving the verification number email? |
Hey @Markkos89 !!
yes, correct, I don't have email notifications in either (=both for negative sentences) email account |
have you check the spam folder? wanna check together? wrote to you on discord |
Hey @Markkos89 - I've just logged in to test this and was shown the code verification modal right away before I was given a chance to enter my email and request the code. I assume this is because I requested a code the first time I tested this flow and was unable to enter it, as when I initially tested this last week, the email didn't arrive. I am, therefore, stuck on this verification screen without any way to fix this as a user. I suspect this highlights a need for someone to request another verification code (a typical flow in these scenarios) if the initial email doesn't arrive for whatever reasons. I am stuck on this screen: |
Hey @Markkos89
Scenario 2:
Scenario 3:
|
Scenario 3 (resumed):
|
…o different modals
Changes
save button disabled
valid email
notification
email stored in database
Next steps