Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp landing page #282

Open
wants to merge 32 commits into
base: staging
Choose a base branch
from

Conversation

rohann06
Copy link

@rohann06 rohann06 commented Sep 11, 2024

Revamped the landing page UI according to the Figma design

Changes

  • Updated the background image for the entire page.
  • Added a new navigation option Posts and its new icon that leads the users to this page.
  • Resized the hero section text layout.
  • Resized both banners also added a gradient border around them.
  • Modified the partner banner by reorganizing the partner logos and the D_D logo.
  • Reconstructed the footer layout to match the Figma design.

kempsterrrr and others added 21 commits August 15, 2024 20:05
* feat: arweave lesson 5 init

* (chore) Clean up Arweave 101 - Lesson 5

* feat: adding meta image for dapp course

* feat: adding final quiz

* fix: updating correct meta image

* feat: Arweave 201 - Gateway Hosting

* feat: init arweave 201, L0&1

* chore: removing arweave 101 L1 and renaming arweave 201 L1

* chore: adding track index page and creating files for meta images

* feat: adding quiz component

* feat: updating quiz components for T1L5 and T2L1

* chore: adding figure for Arweave 201 L1

* chore: updating arweave 201 meta image

* chore: adding meta image for arweave T2L1

* chore: updating final quiz files

* chore: formatting the json in body

---------

Co-authored-by: wolovim <[email protected]>

* chore: removing screenshot from AR quest text (Developer-DAO#268)

* chore: updating arweave T2L1 quest link

* chore: updating arweave T1L5 quest link

* Arweave 201: Lesson 2 (Developer-DAO#273)

* feat: init arweave 201, L2

* chore: arweave201 L2 formatting, figure upload

* chore: meta-image and quiz messaging

* chore: updating Zealy quest link

---------

Co-authored-by: wolovim <[email protected]>
Co-authored-by: K <[email protected]>
removed the old code only for this section and wrote a new one with tailwind css
removed fixed keyword to allow the background image to scroll with the page.
added the learn web3 and partner with banners.
the banner section is complete
added the new dd logo resized all text size and the social icons
changed the design of the navigation bar also added the posts as a new nav option.
added the gradient border to the banners
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:22pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:22pm

Copy link

vercel bot commented Sep 11, 2024

@rohann06 is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Sep 11, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 32
🟢 Accessibility 98
🟠 Best practices 83
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-fork-rohann06-revamp-landingpage-developdao.vercel.app/

@kempsterrrr
Copy link
Member

First PR in, love it @rohann06 - just authorized the deployment and will circle back and take a look later 🫡

If you're free we have the Coordination call for the DAO later @ 3pm UTC in discord. Be good to see you there

updated partner count, adjusted post symbol and full stop graphic in hero, left aligned footer text.
@rohann06
Copy link
Author

I will be there 🙌

@Markkos89
Copy link
Collaborator

@rohann06 can you edit the target branch of the PR to staging?

We use to work locally on a feat/ branch and deploy to staging first.
Then when releasing we create another PR from staging to main.

Thanks

@rohann06 rohann06 changed the base branch from main to staging September 16, 2024 07:09
@Markkos89
Copy link
Collaborator

@rohann06 on every TrackPage and every LessonPage the background image is visible. It should be black background. Can you check? 💪

also on the TrackPages there is margin-top or something, check:

image

In the landing page code, added the background image in the div. This caused it to be removed from
other pages.
@Markkos89
Copy link
Collaborator

@rohann06 can you check this margin-left in the homepage?
image

it's also present on mobile

image

Copy link
Collaborator

@Markkos89 Markkos89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking nicee!
I left two small comments 👍

@@ -11,10 +11,10 @@ const TracksPage: NextPage & { getLayout?: (page: ReactElement) => ReactElement
const { data: allTracksData } = api.tracks.getAll.useQuery();

return (
<div className="flex h-full w-full flex-col space-y-10 overflow-hidden bg-black lg:h-screen lg:max-h-screen lg:flex-row">
<div className=" flex h-screen w-full flex-col space-y-10 overflow-hidden bg-black lg:flex-row">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohann06 Can you check the TracksPage background image? it's broken

image

should be something like this:
image

<nav aria-label="quick links" className="h-20 divide-x">
{links.map((link) => (
<TooltipProvider delayDuration={30} key={link.href}>
<footer className=" absolute bottom-0 z-[999] w-full px-[30px] pb-14">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohann06 on the LessonPage the footer is broken, can you check it? maybe because of the absolute

image

@rohann06
Copy link
Author

@rohann06 can you check this margin-left in the homepage?
image

it's also present on mobile

image

Yess actually, I'm still working on it there are some changes I have to do in lessions page for the footer

@Markkos89
Copy link
Collaborator

Markkos89 commented Sep 19, 2024

gm @rohann06 !
Ca you check FundamentalsPage and TracksPage background?

image

image

I believe it's padding-top or margin-top :)

@rohann06
Copy link
Author

rohann06 commented Sep 19, 2024

It's not the same on my screen. It might be happening because the last two commits are not deployed maybe.

Screenshot 2024-09-19 at 10 08 47 PM

@kempsterrrr
Copy link
Member

Accepted deployment.

Recorded a video to show some strange scroll behaviour I'm seeing - https://www.loom.com/share/2fda5569f551443389c50b4770822a66?sid=fee8c4d3-9b63-4c5f-b8ee-30b45c6d80ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants