-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp landing page #282
base: staging
Are you sure you want to change the base?
Revamp landing page #282
Conversation
* feat: arweave lesson 5 init * (chore) Clean up Arweave 101 - Lesson 5 * feat: adding meta image for dapp course * feat: adding final quiz * fix: updating correct meta image * feat: Arweave 201 - Gateway Hosting * feat: init arweave 201, L0&1 * chore: removing arweave 101 L1 and renaming arweave 201 L1 * chore: adding track index page and creating files for meta images * feat: adding quiz component * feat: updating quiz components for T1L5 and T2L1 * chore: adding figure for Arweave 201 L1 * chore: updating arweave 201 meta image * chore: adding meta image for arweave T2L1 * chore: updating final quiz files * chore: formatting the json in body --------- Co-authored-by: wolovim <[email protected]> * chore: removing screenshot from AR quest text (Developer-DAO#268) * chore: updating arweave T2L1 quest link * chore: updating arweave T1L5 quest link * Arweave 201: Lesson 2 (Developer-DAO#273) * feat: init arweave 201, L2 * chore: arweave201 L2 formatting, figure upload * chore: meta-image and quiz messaging * chore: updating Zealy quest link --------- Co-authored-by: wolovim <[email protected]> Co-authored-by: K <[email protected]>
deploy: arweave 201, lesson 3
deploy: link hotfix
removed the old code only for this section and wrote a new one with tailwind css
removed fixed keyword to allow the background image to scroll with the page.
added the learn web3 and partner with banners.
the banner section is complete
added the new dd logo resized all text size and the social icons
changed the design of the navigation bar also added the posts as a new nav option.
added the gradient border to the banners
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@rohann06 is attempting to deploy a commit to the Developerdao Team on Vercel. A member of the Team first needs to authorize it. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://academy-turbo-git-fork-rohann06-revamp-landingpage-developdao.vercel.app/ |
First PR in, love it @rohann06 - just authorized the deployment and will circle back and take a look later 🫡 If you're free we have the Coordination call for the DAO later @ 3pm UTC in discord. Be good to see you there |
updated partner count, adjusted post symbol and full stop graphic in hero, left aligned footer text.
I will be there 🙌 |
…d clickability across all pages
@rohann06 can you edit the target branch of the PR to We use to work locally on a feat/ branch and deploy to staging first. Thanks |
@rohann06 on every TrackPage and every LessonPage the background image is visible. It should be black background. Can you check? 💪 also on the TrackPages there is margin-top or something, check: |
In the landing page code, added the background image in the div. This caused it to be removed from other pages.
@rohann06 can you check this margin-left in the homepage? it's also present on mobile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking nicee!
I left two small comments 👍
@@ -11,10 +11,10 @@ const TracksPage: NextPage & { getLayout?: (page: ReactElement) => ReactElement | |||
const { data: allTracksData } = api.tracks.getAll.useQuery(); | |||
|
|||
return ( | |||
<div className="flex h-full w-full flex-col space-y-10 overflow-hidden bg-black lg:h-screen lg:max-h-screen lg:flex-row"> | |||
<div className=" flex h-screen w-full flex-col space-y-10 overflow-hidden bg-black lg:flex-row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<nav aria-label="quick links" className="h-20 divide-x"> | ||
{links.map((link) => ( | ||
<TooltipProvider delayDuration={30} key={link.href}> | ||
<footer className=" absolute bottom-0 z-[999] w-full px-[30px] pb-14"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohann06 on the LessonPage the footer is broken, can you check it? maybe because of the absolute
Yess actually, I'm still working on it there are some changes I have to do in lessions page for the footer |
gm @rohann06 ! I believe it's padding-top or margin-top :) |
Accepted deployment. Recorded a video to show some strange scroll behaviour I'm seeing - https://www.loom.com/share/2fda5569f551443389c50b4770822a66?sid=fee8c4d3-9b63-4c5f-b8ee-30b45c6d80ac |
Revamped the landing page UI according to the Figma design
Changes
Posts
and its new icon that leads the users to this page.