This repository has been archived by the owner on Jun 27, 2021. It is now read-only.
Allow customizing timeouts #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
force-pushed
the
customizable_timeouts
branch
from
47d15b3 to
8544af6
Compare
| "timeout_minutes": { | ||
| Type: schema.TypeInt, | ||
| Optional: true, | ||
| Default: 1, // 1 + (n*2) roof 16 = 1+2+4+8+16 = 31 seconds, 1 min should be "normal" operations |
There was a problem hiding this comment.
should it default to 4 to stay consistent with the previous hard-coded default?
There was a problem hiding this comment.
I set this to 4 minutes, more or less baselessly and randomly, to fight some timeouts for a specific project, the 1 minute (as suggested by the comment) is based on maths
mathyourlife-fitbit
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to customize the time the provider backs off for quota issues.
Also replaced some
retry's withretryNotFoundfor #90