Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): prepare for publishing #624

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

devolutionsbot
Copy link
Contributor

🤖 New release

  • ironrdp-server: 0.3.1 -> 0.4.0 (⚠️ API breaking changes)

⚠️ ironrdp-server breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field TlsIdentityCtx.certs in /tmp/.tmppdF5FM/IronRDP/crates/ironrdp-server/src/helper.rs:14

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field cert of struct TlsIdentityCtx, previously in file /tmp/.tmpqM7sOq/ironrdp-server/src/helper.rs:11
Changelog

ironrdp-server

[0.4.0] - 2024-12-17

Features


This PR was generated with release-plz.

@github-actions github-actions bot force-pushed the release-plz/2024-12-17T15-53-11Z branch from e31549a to 5e0e189 Compare December 17, 2024 15:53
@CBenoit
Copy link
Member

CBenoit commented Dec 17, 2024

@elmarco I didn’t catch that in the review, but since we are publishing the crates now, commits which are including breaking changes, should be marked and documented as such according to https://www.conventionalcommits.org/en/v1.0.0/.

(Of course, for now it’s completely fine to have breaking changes as I don’t consider we reached a point where the API is considered stable.)

Copy link

github-actions bot commented Dec 17, 2024

Coverage Report 🤖 ⚙️

Past:
Total lines: 29433
Covered lines: 18625 (63.28%)

New:
Total lines: 29433
Covered lines: 18625 (63.28%)

Diff: +0.00%

[this comment will be updated automatically]

@CBenoit CBenoit enabled auto-merge (squash) December 17, 2024 18:05
@CBenoit CBenoit merged commit 9292988 into master Dec 17, 2024
9 checks passed
@CBenoit CBenoit deleted the release-plz/2024-12-17T15-53-11Z branch December 17, 2024 18:18
@elmarco
Copy link
Contributor

elmarco commented Dec 17, 2024

right indeed, sorry for the unnoticed break (it would be nice to have it noticed during PR),

thanks for the release too, I never expected for it to happen so quickly!

In fact, there is another server fix I would like to have released too.. I guess you can release soon after it again :)

@CBenoit
Copy link
Member

CBenoit commented Dec 17, 2024

right indeed, sorry for the unnoticed break (it would be nice to have it noticed during PR),

We could indeed add a check in the CI just for informational purposes! I do encourage that we adjust the API as much as necessary as long as we are pre 1.x though.
But it’s always nicer to go through a deprecation phase without breaking immediately if possible. (I don’t think it was possible in this case.)

In fact, there is another server fix I would like to have released too.. I guess you can release soon after it again :)

Yes, no problem! Now that the process is automatized you can expect things to be released much faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants