Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central opa deployment #167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Central opa deployment #167

wants to merge 6 commits into from

Conversation

garryod
Copy link
Member

@garryod garryod commented Sep 16, 2024

Requires #164

@garryod garryod added enhancement New feature or request helm Pull request that updates Helm charts labels Sep 16, 2024
@garryod garryod self-assigned this Sep 16, 2024
@garryod garryod marked this pull request as draft September 16, 2024 15:01
@garryod garryod force-pushed the central-opa-deployment branch 11 times, most recently from 19fd727 to 78b9ba8 Compare September 17, 2024 15:49
@garryod garryod marked this pull request as ready for review September 17, 2024 15:56
Copy link
Collaborator

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will discuss tomorrow

- path: /
pathType: Prefix
- path: /bundle.tar.gz
pathType: ImplementationSpecific
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Diamond Kyverno policy disallowed this?

Copy link
Member Author

@garryod garryod Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an exception which can be granted. If Prefix or Exact are used then paths with separators (.) in them are disallowed

@@ -27,7 +27,7 @@ extraEnv: []
portOverride: ""

serviceAccount:
create: false
create: true
name: ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to create a SA with name "default"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the name of the deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Pull request that updates Helm charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants