Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a system for beamline specific zebra constants #772

Open
DominicOram opened this issue Sep 4, 2024 · 0 comments
Open

Come up with a system for beamline specific zebra constants #772

DominicOram opened this issue Sep 4, 2024 · 0 comments

Comments

@DominicOram
Copy link
Contributor

Zebras on different beamlines tend to be wired differently. It is useful to refer to e.g. which output different hardware is on via a nicely named constant rather that the output number. In zebra.py we have some constants defined e.g. EIGER_TTL but these are only valid for i03. Ideally we would have these defined for other beamlines in a way that we can do:

def my_plan(zebra):
    yield from abs_set(zebra.in_1, DETECTOR_TTL)

and this works for any beamline. For example we could do this by when instantiating the zebra we also pass in the constants mapping.

Acceptance Criteria

  • Nicely named Zebra constants are defined for all MX beamlines where we currently use bluesky
  • It's clear which beamline, and which zebra, these constants are for
  • We can easily write generic plans that will use these constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant