Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to control shutter source #770

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

DominicOram
Copy link
Contributor

See DiamondLightSource/mx-bluesky#232

Instructions to reviewer on how to test:

  1. Confirm dodal connect i03 works

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (08c2764) to head (9e0e09a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files         115      115           
  Lines        4622     4630    +8     
=======================================
+ Hits         4370     4378    +8     
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram marked this pull request as ready for review September 2, 2024 19:57
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestions in the comments. Also, I didn't verify that

AUTO_SHUTTER_GATE = 2
AUTO_SHUTTER_INPUT = 1

are correct. On a separate note, some of the constants in that file are specific to i03's Zebra - that might be misleading to other beamlines

src/dodal/devices/zebra_controlled_shutter.py Outdated Show resolved Hide resolved
src/dodal/devices/zebra_controlled_shutter.py Outdated Show resolved Hide resolved
@DominicOram
Copy link
Contributor Author

On a separate note, some of the constants in that file are specific to i03's Zebra - that might be misleading to other beamlines

I've made #772 to clean this all up

@DominicOram DominicOram merged commit 4130b0f into main Sep 5, 2024
18 checks passed
@DominicOram DominicOram deleted the mx_bluesky_232_shutter_control branch September 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants