-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to control shutter source #770
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 94.54% 94.55%
=======================================
Files 115 115
Lines 4622 4630 +8
=======================================
+ Hits 4370 4378 +8
Misses 252 252 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestions in the comments. Also, I didn't verify that
AUTO_SHUTTER_GATE = 2
AUTO_SHUTTER_INPUT = 1
are correct. On a separate note, some of the constants in that file are specific to i03's Zebra - that might be misleading to other beamlines
I've made #772 to clean this all up |
See DiamondLightSource/mx-bluesky#232
Instructions to reviewer on how to test:
dodal connect i03
worksChecks for reviewer
dodal connect ${BEAMLINE}