-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read aperture/scatterguard hardware on read #782
Comments
|
I wonder if we should try and write a general rule in the docs of "devices should avoid holding state and instead read the state of the hardware when read"? Thoughts @callumforrester, @dperl-dls, @coretl? |
Would be nice if there was some utility for making a soft_signal backed by some function that may read other parts of device state |
I agree that that is a good guideline to have for people writing devices |
Following #769 a side effect of this is that we're no longer reading the state of the hardware whenever we read
selected_aperture
. This means that the device itself is holding on to the state of the beamline based on what state it last moved to. This means that the state could be wrong if:Acceptance Criteria
The text was updated successfully, but these errors were encountered: