-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read hardware on every read of the aperture scatterguard #789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 94.99% 95.01% +0.01%
==========================================
Files 115 116 +1
Lines 4737 4753 +16
==========================================
+ Hits 4500 4516 +16
Misses 237 237 ☔ View full report in Codecov by Sentry. |
Co-authored-by: DiamondJoseph <[email protected]>
This is better than what was there originally, but I'm concerned that you don't override I wonder if there is a case for supplying both a |
Yh, I agree but this is going to be hard. I guess the correct solution is to subscribe to all the signals you derive from then recalculate the derivation and push an update when any of them change.
Yep, I think we will need these in the generic case. Can we push the full solution to bluesky/ophyd-async#525 and treat this as a first pass example of how you could do it but with it's limitations? I would be happy to help contribute to the full solution but given it's a reasonably large feature, with quite a few stakeholders it will take a while and I would rather not have this bug in |
Sounds good to me, could we have a comment to this effect in the code please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like comments have been addressed.
Thanks, this is useful!
Fixes #782
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}