Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asyncio wrapped TimeoutError after support for Python 3.10 dropped #797

Open
DiamondJoseph opened this issue Sep 20, 2024 · 1 comment
Open

Remove asyncio wrapped TimeoutError after support for Python 3.10 dropped #797

DiamondJoseph opened this issue Sep 20, 2024 · 1 comment
Labels
enhancement New feature or request low priority Not needed for production in the near future python Pull requests that update Python code

Comments

@DiamondJoseph
Copy link
Contributor

asyncio.TimeoutError was removed from Python 3.11, deferring to the builtin TimeoutError. asyncio still exposes the builtin, but after we no longer support Python 3.10 we will not require to and intent is clearer just using the builtin.

Acceptance Criteria

  • Wherever TimeoutError is imported from asyncio is removed, and the builtin TimeoutError is used
  • Wherever asyncio.TimeoutError is used, it is replaced with the builtin TimeoutError
@DiamondJoseph DiamondJoseph mentioned this issue Sep 20, 2024
Merged
4 tasks
@DiamondJoseph DiamondJoseph added enhancement New feature or request python Pull requests that update Python code low priority Not needed for production in the near future labels Sep 20, 2024
@DiamondJoseph
Copy link
Contributor Author

N.B.: Under SPEC0 3 years from Python 3.10 release is October 4th 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority Not needed for production in the near future python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DiamondJoseph