-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ophyd-async 0.6.0 #796
Conversation
58b6595
to
9245088
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 94.90% 94.91%
=======================================
Files 115 115
Lines 4675 4677 +2
=======================================
+ Hits 4437 4439 +2
Misses 238 238 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise looks good.
Given the tests are on 3.10 only and mention timeouts I'm going to bet that they're to do with |
For now I've imported TimeoutError from asyncio: in 3.10 this will be the asyncio.TimeoutError, in >3.10 this returns the builting TimeoutError. Either TypeChecking will shout at us or there's this ticket to remove the import after 3.10 |
Fixes #794
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}