Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move beamstop to use an XYZPositioner and remove old device #695

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #685

Instructions to reviewer on how to test:

  1. Confirm tests still pass
  2. Confirm dodal connect i04 passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (1ff9784) to head (2372f40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   94.46%   94.46%   -0.01%     
==========================================
  Files         116      115       -1     
  Lines        4611     4604       -7     
==========================================
- Hits         4356     4349       -7     
  Misses        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram merged commit 851a002 into main Aug 27, 2024
18 checks passed
@DominicOram DominicOram deleted the 685_convert_beamstop_to_ophyd_async branch August 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to ophyd-async: beamstop
2 participants