Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in MJPG stream and fix system test #777

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #776

Instructions to reviewer on how to test:

  1. Run pyright . and confirm there's no errors
  2. Comment out the skip on test_grid_overlay
  3. Run this test and confirm that snapshot images are written to the top folder

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperion#183

Opportunity to prioritise #716 and continue moving off ophyd?

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (4130b0f) to head (31aba2a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         115      115           
  Lines        4630     4631    +1     
=======================================
+ Hits         4378     4379    +1     
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram merged commit c4051ba into main Sep 5, 2024
18 checks passed
@DominicOram DominicOram deleted the 776_fix_linting_on_http branch September 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting failing on main
2 participants