-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pressure jump outline #97
pressure jump outline #97
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
===========================================
- Coverage 47.96% 33.86% -14.10%
===========================================
Files 9 10 +1
Lines 221 313 +92
===========================================
Hits 106 106
- Misses 115 207 +92 ☔ View full report in Codecov by Sentry. |
1746587
to
a471396
Compare
time2=in_micros(deadtime), | ||
outa2=True, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
row for the triggering , hold the pressure cell trigger high until end of experiment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? not sure what does that mean - should I add this as documentation, or add another row to hold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiamondJoseph any updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually all the outs are set to True in all the other frames
todo: update with notes from the meeting |
1, 3 pressure must be less than 50 bar. for rise 5 mst be open, for loss 6 must be open transducer aka chamber read for cell - 3 pump is fast configuration is jsut 11 PVs; 3 per valbe, and fast ones as extra on joining the volumes, the pressure would fall we do not want any air, it would cause the diagram to wobble and various issues the physical orde ris pump - v3 - inter -> v5/v6 - celll match inter pressure cell pressure, then just raise the pump there are some plugins in GDA there is pressure_from, pressure_to, etc, and old style of TFG table "1110111" etc binary string |
todos
|
975ab30
to
a76482f
Compare
ideally should take into account this issue too DiamondLightSource/dodal#759 |
a76482f
to
e3c1703
Compare
not sure about the wiring