Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressure jump outline #97

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

stan-dot
Copy link
Collaborator

not sure about the wiring

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code labels Aug 22, 2024
@stan-dot stan-dot self-assigned this Aug 22, 2024
@stan-dot stan-dot linked an issue Aug 22, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (1f0a008) to head (a471396).

Files Patch % Lines
src/i22_bluesky/plans/pressure_jump.py 0.00% 92 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1f0a008) and HEAD (a471396). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (1f0a008) HEAD (a471396)
6 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #97       +/-   ##
===========================================
- Coverage   47.96%   33.86%   -14.10%     
===========================================
  Files           9       10        +1     
  Lines         221      313       +92     
===========================================
  Hits          106      106               
- Misses        115      207       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot stan-dot force-pushed the 79-create-a-plan-for-november-pressure-jump-experiment branch from 1746587 to a471396 Compare August 22, 2024 10:27
time2=in_micros(deadtime),
outa2=True,
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

row for the triggering , hold the pressure cell trigger high until end of experiment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? not sure what does that mean - should I add this as documentation, or add another row to hold?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiamondJoseph any updates?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually all the outs are set to True in all the other frames

@stan-dot
Copy link
Collaborator Author

todo: update with notes from the meeting

@stan-dot
Copy link
Collaborator Author

1, 3 pressure must be less than 50 bar. for rise 5 mst be open, for loss 6 must be open

transducer aka chamber
p1 pump, p2 intermediate, p3 sample
static scanspec

read for cell - 3

pump is fast

configuration is jsut 11 PVs; 3 per valbe, and fast ones as extra

on joining the volumes, the pressure would fall

we do not want any air, it would cause the diagram to wobble and various issues

the physical orde ris pump - v3 - inter -> v5/v6 - celll

match inter pressure cell pressure, then just raise the pump

there are some plugins

in GDA there is pressure_from, pressure_to, etc, and old style of TFG table "1110111" etc binary string

@stan-dot
Copy link
Collaborator Author

todos

  • start the plan with the confirmation of values

1, 3 pressure must be less than 50 bar. for rise 5 mst be open, for loss 6 must be open

  • make a stub just to adjust those, add it to a third plan
  • just increase the pressure and assert that it's higher at the end
  • ignore the detectors for the small test

@stan-dot stan-dot force-pushed the 79-create-a-plan-for-november-pressure-jump-experiment branch from 975ab30 to a76482f Compare September 23, 2024 15:46
@stan-dot
Copy link
Collaborator Author

ideally should take into account this issue too DiamondLightSource/dodal#759

@stan-dot stan-dot marked this pull request as ready for review October 2, 2024 14:35
@stan-dot stan-dot force-pushed the 79-create-a-plan-for-november-pressure-jump-experiment branch from a76482f to e3c1703 Compare November 14, 2024 10:58
@stan-dot stan-dot merged commit 7a381cc into main Nov 14, 2024
12 of 16 checks passed
@stan-dot stan-dot deleted the 79-create-a-plan-for-november-pressure-jump-experiment branch November 14, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a plan for pressure jump experiment
2 participants