Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMAC: Correct responses to basic axis commands #10

Open
MattPrit opened this issue Aug 16, 2022 · 0 comments
Open

PMAC: Correct responses to basic axis commands #10

MattPrit opened this issue Aug 16, 2022 · 0 comments
Labels
pmac Tickets required for simulated PMAC

Comments

@MattPrit
Copy link
Collaborator

MattPrit commented Aug 16, 2022

Part of #2
Some PMAC axis commands can be sent in multiple ways with different responses expected. The PMAC simulation will need to be able to handle them correctly in both ways.
For example, consider the command to set the current axis to 2 and read the current position. This can be sent as either two separate 'words', #2 P, or as a single word, #2P. Both will have the same effect on the PMAC, but the number of responses from the PMAC should be the same as the number of words in. Hence, we must parse the one word case such that it is interpreted as the two word case, but later combine the results of these into a single reply.
This will require DiamondLightSource/tickit#82 to implement the correct message-splitting behavior within the device's message interpreter.

Acceptance Criteria

  • PMAC simulator responds with the following:
    • #1 P -> \r3\r\n
    • #1P -> 3\r\n
  • Where P is running the same command in each case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pmac Tickets required for simulated PMAC
Projects
None yet
Development

No branches or pull requests

2 participants