#18: PMAC: start dls-pmac-control #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPrit
changed the title
abbiemery
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add missing modules to API documentation * Update docs/reference/api.rst Co-authored-by: Garry O'Donnell <[email protected]> * Update docs/reference/api.rst Co-authored-by: Garry O'Donnell <[email protected]> * Fix incorrect indentation * Suppress warnings during building of docs * Add Status and ExtendedStatus to docs Classes added to docs and reference links are now working. * Revert commenting-out It was not supposed to be committed. * Remove `class` and replace `optional` with `Optional` Co-authored-by: Garry O'Donnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 #10
Requires #19 #17 #15
Needs DiamondLightSource/tickit#90
Adds minimal functionality for dls-pmac-control to connect and poll the PMAC. To test this (at DLS): run
dls-pmac-control.py, select the protocol as 'TCP/IP Ethernet', connect to localhost:1025 with the simulation running locally (python -m tickit all examples/configs/pmac.yaml) and enable polling.To understand commands sent from dls-pmac-control, the
MultiCommandInterpreterfrom DiamondLightSource/tickit#90 is required.