Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulate a PMAC #2

Open
DominicOram opened this issue Aug 9, 2022 · 0 comments
Open

Simulate a PMAC #2

DominicOram opened this issue Aug 9, 2022 · 0 comments
Assignees
@MattPrit
Labels
pmac Tickets required for simulated PMAC

Comments

@DominicOram
Copy link
Contributor

There is already a simulation for a PMAC but not in tickit, we should adapt it.
@DominicOram DominicOram mentioned this issue Aug 9, 2022
Closed
This was referenced Aug 16, 2022
Open
Open
Open
Open
Open
Merged
abbiemery pushed a commit that referenced this issue Jun 15, 2023
@garryod @collang @OCopping
Draft: Use pydocstyle (#2)
1cf7099 
* Install pytest-pydocstyle

* Configure pytest to use pydocstyle

* Lock with DLS PyPi

* Ignore module & package docstrings

* Fix loading docstrings

* Fix configurable docstrings

* Fix topic_naming docstrings

* Fix singleton docstrings

* Fix byte_format docstrings

* Fix source docstrings

* Fix sink docstrings

* Fix state_interface docstrings

* Bump pydocstyle to 6.1.1

* Fix kafka docstrings

* Fix internal docstrings

* Fix slave docstrings

* Fix master docstrings

* Fix base docstrings

* Fix ticker docstrings

* Fix device_simulation docstrings

* Fix system_simulation docstrings

* Fix component docstrings

* Fix typedefs docstrings

* Fix lifetime_runnable docstrings

* Fix device docstrings

* Fix adapter docstrings

* Fix tcp docstrings

* Fix regex_command docstrings

* Fix command_interpreter docstrings

* Fix composed docstrings

* Fix remote_controlled docstrings

* Fix shutter docstrings

* Fix trampoline docstrings

* Fix _version_git docstrings

* Re-lock pipfile.lock

* Add cli docstrings

* Add D418 to pydocstyle ignore

* Fix event_router docstrings

* Refactor epicsadapter

* Update EpicsAdapter adapters

* Update example configs

* Fix base docstrings

* Fix shutter docstrings

* Fix cryostream docstrings

* Fix states docstrings

* Fix status docstrings

* Enable pydocstyle linting

* Add simple docstrings to pneumatic

* Make flake8 complient

* Added docstrings to femto.py; Changed 'records' function in femto, pneumatic and epicsadapter to 'on_db_load' to better reflect what it does; Updated Pipfile to include charset-normalizer

* Fixed some docstring formatting

* Fixed line lengths

* Update tickit/devices/pneumatic/pneumatic.py

Co-authored-by: Garry O'Donnell <[email protected]>

* Removed whitespace

* Changed a couple of docstrings to include args and return values

* Remove charset-normalizer

* Edited set_state function

* Fix typechecking error

Co-authored-by: Angus Collett <[email protected]>
Co-authored-by: Ollie Copping <[email protected]>
@abbiemery abbiemery added the pmac Tickets required for simulated PMAC label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattPrit MattPrit

Labels
pmac Tickets required for simulated PMAC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DominicOram @MattPrit @abbiemery