-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
26 create oav device #27
base: main
Are you sure you want to change the base?
Conversation
Set up the PVs so they are broadcasted from a json. Will need to add setters
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 84.30% 86.00% +1.69%
==========================================
Files 3 4 +1
Lines 172 250 +78
==========================================
+ Hits 145 215 +70
- Misses 27 35 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I like the fake pin shapes! Could you address the minor comments in code and remove the empty MO-IOC.db
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On starting the IOCs I get a bunch of errors about asyn
links and I/O Intr not valid
. Can you set them to soft records or remove them to make sure it doesn't error
Acceptance criteria:
Fixes #26