Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26 create oav device #27

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

26 create oav device #27

wants to merge 16 commits into from

Conversation

evalott100
Copy link
Collaborator

@evalott100 evalott100 commented Nov 24, 2022

Acceptance criteria:

  • Set up all the PVs used in the operation of OAV centring.

Fixes #26

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #27 (5fe9143) into main (2461275) will increase coverage by 1.69%.
The diff coverage is 89.74%.

❗ Current head 5fe9143 differs from pull request most recent head 9c74854. Consider uploading reports for the commit 9c74854 to get more accurate results

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   84.30%   86.00%   +1.69%     
==========================================
  Files           3        4       +1     
  Lines         172      250      +78     
==========================================
+ Hits          145      215      +70     
- Misses         27       35       +8     
Impacted Files Coverage Δ
tickit_devices/oav/oav_edge_detection.py 89.74% <89.74%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I like the fake pin shapes! Could you address the minor comments in code and remove the empty MO-IOC.db file?

tickit_devices/oav/oav_edge_detection.py Outdated Show resolved Hide resolved
tickit_devices/oav/oav_edge_detection.py Outdated Show resolved Hide resolved
tickit_devices/oav/oav_edge_detection.py Show resolved Hide resolved
tickit_devices/oav/oav_edge_detection.py Outdated Show resolved Hide resolved
s03_configs/oav.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On starting the IOCs I get a bunch of errors about asyn links and I/O Intr not valid. Can you set them to soft records or remove them to make sure it doesn't error

tickit_devices/oav/oav_edge_detection.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create OAV device
2 participants