Rename scheduler #188
Merged
Rename scheduler #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 41 41
Lines 1318 1318
=======================================
Hits 1248 1248
Misses 70 70
☔ View full report in Codecov by Sentry. |
abbiemery
force-pushed
the
rename-scheduler
branch
from
92acc32
to
4ee6bb8
Compare
abbiemery
force-pushed
the
rename-scheduler
branch
from
4ee6bb8
to
aaa0c61
Compare
tpoliaw
requested changes
Sep 26, 2023
There was a problem hiding this comment.
There are still references to slave schedulers in two of the diagrams in the docs
docs/images/tickit-simple-overview-with-system-simulation.svg
docs/images/tickit-system-simulation-cpt.svg
There are also two files with references in the names
tests/core/management/schedulers/test_slave_scheduler.py
tests/system_tests/test_with_master_and_slave.py
aaa0c61
to
3db9b36
Compare
tpoliaw
approved these changes
Sep 26, 2023
abbiemery
force-pushed
the
rename-scheduler
branch
from
b2f6b19
to
37aa9af
Compare
abbiemery
added a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168