Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the version bounds on platformdirs to >= 3 #1137

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

ptrcnull
Copy link
Collaborator

@ptrcnull ptrcnull commented Jun 25, 2024

fixes #1136

as a side note, should we update HISTORY.rst with every single change, under a "not released yet" header? it might make things easier on release, as we won't have to go through all the commits to check what was changed

@ptrcnull ptrcnull requested a review from getzze June 25, 2024 13:12
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

as a side note, should we update HISTORY.rst with every single change, under a "not released yet" header? it might make things easier on release, as we won't have to go through all the commits to check what was changed

I would suggest to remove this file and use a generator to craft GitHub releases instead. I don't have recommendations as I don't know those tools but I'm pretty sure some popular projects use them (maybe FastAPI?)

@getzze
Copy link
Collaborator

getzze commented Jun 25, 2024

I saw some project using towncrier but I have never used it myself (EDIT: attrs).

In the meantime, I think it's a good idea to write HISTORY.rst for each commit, good point.

@ptrcnull
Copy link
Collaborator Author

I would suggest to remove this file and use a generator to craft GitHub releases instead. I don't have recommendations as I don't know those tools but I'm pretty sure some popular projects use them (maybe FastAPI?)

IMHO it's way more useful to have a changelog file, since it's not tied to GitHub and you can just look it up when you have the repo checked out locally

@ptrcnull
Copy link
Collaborator Author

I think it's a good idea to write HISTORY.rst for each commit

i'd say each merge request? ideally so that the changelog makes sense for users who don't exactly have to know how Subliminal actually works

@ptrcnull ptrcnull force-pushed the platformdirs branch 2 times, most recently from a82bff9 to 8cbc201 Compare June 25, 2024 15:40
@ptrcnull ptrcnull merged commit 3af7fe5 into main Jun 25, 2024
20 checks passed
@ptrcnull ptrcnull deleted the platformdirs branch June 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FYI: Subliminal 2.2.0 can not be used in Fedora and derivatives.
3 participants