Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference or avoidance per language type (hearing impaired, foreign only) #1175

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Oct 7, 2024

closes #535
partly solves #925

Currently, we can only choose to prefer hearing impaired subtitles (among subtitles with the same highest score) with the "-hi" option. This PR adds the following:

  • Add cli option "-HI" to prefer non-hearing-impaired subtitles, negation of existing "-hi".
  • Add cli options "-fo" and "-FO" to prefer (or disfavor, respectively) foreign-only/forced subtitles.

"-hi" takes precedence over "-fo" and "-FO" (it cannot be used with "-HI").
"-fo" takes precedence over "-HI" (it cannot be used with "-FO").
Using "-HI" and "-FO" together is redundant and equivalent of using just one of the options.

However, not all providers are reporting foreign_only tags for subtitles (added opensubtitles.com support in this PR).

Other:

@getzze
Copy link
Collaborator Author

getzze commented Oct 7, 2024

Also I didn't modify the scores, I will do it in another PR when adding an fps match.

@getzze getzze marked this pull request as ready for review October 8, 2024 20:49
@getzze getzze merged commit 0c4a957 into Diaoul:main Nov 4, 2024
21 checks passed
@getzze getzze deleted the language-type-selection branch November 4, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect hearing impaired subtitles when the provider doesn't give the information
1 participant