Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow episode search without episode number #702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evuez
Copy link

@evuez evuez commented Oct 12, 2016

This fixes #692.

Not finding the episode number shouldn't raise an error, most of the time
it actually works without one anyway.

This fixes Diaoul#692.

Not finding the episode number shouldn't raise an error, most of the time
it actually works without one anyway.
@coveralls
Copy link

coveralls commented Oct 12, 2016

Coverage Status

Coverage remained the same at 91.821% when pulling ff6ae65 on evuez:allow-no-number into 7eb7a53 on Diaoul:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.821% when pulling ff6ae65 on evuez:allow-no-number into 7eb7a53 on Diaoul:develop.

@fernandog
Copy link
Collaborator

@evuez I would check episode number OR 'date' as in guessit result:

guessit "Panorama.2016.06.29.Iraq.The.Final.Judgement.720p.WEB-DL.h264-OmarMateen.mkv"
For: Panorama.2016.06.29.Iraq.The.Final.Judgement.720p.WEB-DL.h264-OmarMateen.mkv
GuessIt found: {
    "title": "Panorama",
    "date": "2016-06-29",
    "country": "IRAQ",
    "episode_title": "The Final Judgement",
    "screen_size": "720p",
    "format": "WEB-DL",
    "video_codec": "h264",
    "release_group": "OmarMateen",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}

Because it can't have an episode number and also can't be air by date

Copy link
Collaborator

@fernandog fernandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check date from guessit

@fernandog
Copy link
Collaborator

@evuez
Also all providers needs to be changed to add a "match" when date is equal in both video and subtitle

@fernandog
Copy link
Collaborator

fernandog commented Dec 3, 2017

@Diaoul how to proceed with this? as the air-by-date would override season and episode. The score system will need to be changed. And as discussed in our talk, we should consider add edition and streaming_services to the score too. Maybe we can do all this in a new PR

ping @pannal @ratoaq2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants