Merge pull request #32 from DiceTechnology/fix/audio-text-null-checks

fix: adding null checks and renaming isoCode and url
DiceTechnology · Apr 25, 2019 · 5868378 · 5868378
2 parents 5058c9a + b2529aa
commit 5868378
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ios/ReactVideoSubtitleSideloader/ReactVideoSubtitleSideloader/SubtitleTrack.swift b/ios/ReactVideoSubtitleSideloader/ReactVideoSubtitleSideloader/SubtitleTrack.swift
@@ -21,8 +21,8 @@ import Foundation
     }
 
     @objc public static func from(dict: NSDictionary) -> SubtitleTrack? {
-        guard let iso = dict["isoCode"] as? String,
-            let urlString = dict["url"] as? String, let url = URL(string: urlString) else {
+        guard let iso = dict["language"] as? String,
+            let urlString = dict["uri"] as? String, let url = URL(string: urlString) else {
                 return nil
         }
         let name =

diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -1244,12 +1244,14 @@ - (void)setMediaSelectionTrackForCharacteristic:(AVMediaCharacteristic)character
 }
 
 - (void)setSelectedAudioTrack:(NSDictionary *)selectedAudioTrack {
+    if (!selectedAudioTrack) return;
     _selectedAudioTrack = selectedAudioTrack;
     [self setMediaSelectionTrackForCharacteristic:AVMediaCharacteristicAudible
                                         withCriteria:_selectedAudioTrack];
 }
 
 - (void)setSelectedTextTrack:(NSDictionary *)selectedTextTrack {
+    if (!selectedTextTrack) return;
   _selectedTextTrack = selectedTextTrack;
   if (_textTracks) { // sideloaded text tracks
     [self setSideloadedText];