Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse posts on tap (Apollo-style) #2153

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented Aug 3, 2024

Fixes #1950

With this PR threads are now collapsed instead of focused when tapped:

RPReplay_Final1722652629.MP4

This is similar to how apps like Apollo, Mlem and other apps with hierarchical comments handle this. In its current state, the PR replaces the focus-on-tap behavior for any indented replies, if desired, I could see a few ways of reconciling the old/current behavior with this though:

  • Provide a focus action as a separate context menu
  • Provide a setting for changing the "tap" action (i.e. focus or collapse)
    • Perhaps we could rename the "Swipe Actions" settings to a more general "Gestures" and put it there?

Would love to hear some thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Tap to Collapse Reply Threads
1 participant