Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reexport the Warning trait in dioxus-signals #3321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Reexport the Warning trait in dioxus-signals #3321

wants to merge 1 commit into from

Conversation

marc2332
Copy link
Contributor

feat: Reexport the Warning trait in dioxus-signals to allow the use of ::allow() without pulling the warnings crate

@marc2332
feat: Reexport the Warning trait in dioxus-signals to allow the use…
8fdd1b4 
… of `::allow()` without pulling the warnings crate
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Dec 11, 2024 •
edited
Loading

Maybe we should be re-exporting warnings from the dioxus namespace?

dioxus::warnings::allow()

@marc2332
Copy link
Contributor Author

Maybe we should be re-exporting warnings from the dioxus namespace?

dioxus::warnings::allow()

In dioxus-lib as well if that was the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc2332 @jkelleyrtp