Fix remote image urls

DioxusLabs · Oct 5, 2024 · dfd4a72 · dfd4a72
1 parent 3f8e2b4
commit dfd4a72
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/mdbook-macro/src/lib.rs b/mdbook-macro/src/lib.rs
@@ -87,7 +87,7 @@ fn generate_router(book_path: PathBuf, book: mdbook_shared::MdBook<PathBuf>) ->
     let book_pages = book.pages().iter().map(|(_, page)| {
         let name = path_to_route_variant(&page.url);
         // Rsx doesn't work very well in macros because the path for all the routes generated point to the same characters. We manually expand rsx here to get around that issue.
-        match rsx::parse(page.url.clone(), &page.raw, ) {
+        match rsx::parse(page.url.clone(), &page.raw) {
             Ok(rsx) => {
                 quote! {
                     #[component(no_case_check)]

diff --git a/mdbook-macro/src/rsx.rs b/mdbook-macro/src/rsx.rs
@@ -359,7 +359,15 @@ impl<'a, I: Iterator<Item = Event<'a>>> RsxMarkdownParser<'a, I> {
                     syn::parse_quote!(#dest)
                 };
                 #[cfg(feature = "manganis")]
-                let url: syn::Expr = syn::parse_quote! { manganis::mg!(file(#dest)) };
+                let url: syn::Expr = {
+                    let remote_image = dest.starts_with("http:") || dest.starts_with("https:");
+                    if remote_image {
+                        let dest = escape_text(dest);
+                        syn::parse_quote!(#dest)
+                    } else {
+                        syn::parse_quote! { manganis::mg!(file(#dest)) }
+                    }
+                };
 
                 self.start_node(parse_quote! {
                     img {
@@ -403,7 +411,10 @@ impl<'a, I: Iterator<Item = Event<'a>>> RsxMarkdownParser<'a, I> {
         if let (Some(BodyNode::Text(last_text)), BodyNode::Text(new_text)) =
             (element_list.last_mut(), &node)
         {
-            last_text.input.formatted_input.push_ifmt(new_text.input.formatted_input.clone());
+            last_text
+                .input
+                .formatted_input
+                .push_ifmt(new_text.input.formatted_input.clone());
         } else {
             element_list.push(node);
         }