Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and replaced React.createClass #3

Open
wants to merge 3 commits into
base: 1.10.2
Choose a base branch
from

Conversation

mullojo
Copy link
Collaborator

@mullojo mullojo commented Jul 1, 2020

Progress made today

Searched and replaced React.createClass
Added all needed import statements

import createReactClass from 'create-react-class';
import PropTypes from 'prop-types';
@mullojo mullojo mentioned this pull request Jul 1, 2020
11 tasks
@jankapunkt jankapunkt changed the base branch from master to 1.10.2 July 1, 2020 09:35
@mullojo
Copy link
Collaborator Author

mullojo commented Jul 2, 2020

Hi @SachaG! So I've looked into the project code here a bit more to get an idea of how everything was designed to populate the database and then run nicely. I've got a couple questions about what you might like as an ideal direction for this project in your mind.

I think we can get this all working, although maybe you mentioned something about Ruby and how that might have been part of this project as a tool used to load content into the database? Could you elaborate more on that?

Can you elaborate a bit more about how your remember everything working?

Here are a couple of details you might like to think about as options too:

  • Book chapter content is here: https://github.com/DiscoverMeteor/DiscoverMeteorBook/tree/master/server/chapters (these are .erb files, which stands for 'Embedded Ruby' (aka 'markdown embedded in Ruby'). The contents of the file text is mostly markdown, so I was able to begin an import experiment into a Community GitBook that might be a prefered way to edit & maintain the book longer term.
  • Check out the start to the GitBook here, let us know how you feel about this option. There is some syntax that is not markdown in the .erb files, but we can easily edit that and put in things like images, etc. maybe with only a couple hours of work.
  • If you like that option, then I'd like to invite you and anyone else who might want to be editors/admins in that GitBook. It seems like just serendipitous timing, but I was just getting started rolling out our "free open source" access to all the GitBooks the community can co-create, so it would be fun to have your project in there 👍
  • GitBooks are wonderful to edit in and make one of the best online reading & searching doc/guide/book tools available on the web today. I feel this is important because things change so fast in the JS/web world these days that it's important to keep thing updated to stay relevant. Also I'm kind of going to encourage people to make it easy to "donate" or "give back" to the creators of a book, because this is the "open source thank you" in the world today. 🌎🙏
  • If you like this idea, I'll finish the import to get you back to baseline, then it would be cool to actually update outdated writing and instructions in the book. I'm writing a GitBook for Vue + Meteor and still building a very large app of my own, but I'm super passionate about growing Meteor as an open source community, so really taking time out to support that goal.

For the app, I would love to get it running smoothly, so maybe we could document it better in the GitBook and use it as a community teaching/reference project. But I also want to make sure this would be a vision that you would like. It's a great "example" app in my opinion with code that shows some nice examples of how to do things with Meteor.

I'm also very flexible and mostly want to do this as a favor to you for being part of the Meteor Community & getting so many early people interested in Meteor. It's a nice chance to give back. Let us know what you think/feel. ❤️

@SachaG
Copy link
Member

SachaG commented Oct 23, 2020

I'm really sorry, I just realized I never followed up on this! I don't have much time to work on this right now so I just gave you write access to the repo to make things a bit easier. Let me know if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants