Fix warnings and rebase master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunck length. This reverts the implementation back to what it was to not break any existing clients.
The current callback api is quite painful to use. This is a first (so far non-breaking) change to make it a bit more usable. I'll have to rework it soon. Signed-off-by: Dzenan Jupic <[email protected]>
- Make the progress bar a CLI option - Print progress bar to stderr - Remove the use of `blocking` - Add error handling - Get rid of redundant `counter` variable Signed-off-by: Dzenan Jupic <[email protected]>
Signed-off-by: Dzenan Jupic <[email protected]>
Signed-off-by: Dzenan Jupic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have write access on your PR branch, so here's a PR for the PR.
It's a rebase of
masterso no way to fast-forward merge it.