Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(member): implement member banners #1204
base: master
Are you sure you want to change the base?
feat(member): implement member banners #1204
Changes from all commits
d2a55ea
c205924
bd2c32a
1d701c5
e3b7892
1054c4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a
display_banner
field would be a good QOL addition, which also keeps it in line with avatars and decorationsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has no reason to exist, as it is non-functional, as the API only returns the user banners on fetched users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gateway doesn't send user banners, but REST does, so this works fine with
guild.fetch_member
which also returns user data for the requested member.The caveat here is that the user can't be cached yet, since
store_user
will prefer the cached user (without banner) over the passed user data (with banner):disnake/disnake/member.py
Lines 328 to 330 in 93de3c8
Improving this is out of scope here, but
display_banner
isn't completely useless either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how it functions, given its a bit of a footgun in its current state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, fair enough; it is somewhat inconsistent.
In that case, I suppose
display_banner
would be better suited as aTODO
for the future, once theMemberWithUserPayload
handling improves a bit. Bit unfortunate, but you're right.