-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the Manifold Visualizer #437
Comments
Hi! I wanted to work on the frameon feature? Is that still up for grabs? |
hi @jimmyshah Thanks for your interest in contributing to yellowbrick. however we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your contribution. |
@lwgray Thank you for the quick response! Sounds good to me, I'm excited to contribute! |
Adds frameon param to Manifold to address a part of #437
Hello again! I was interested in working on the n_neighbors attribute issue, is that one still available? |
hi @jimmyshah Let me again Thank you for your last contribution to yellowbrick. In regard to your currest ask, we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your next contribution. |
Hey there @jimmyshah and welcome back! The maintainers don't generally assign issues to contributors (we're only 5-6 people so that would be a bit too much management overhead for us), so the best strategy is to check if there's already an open PR addressing the issue (which in this case, there isn't... yet! 😉) Look forward to seeing your next PR! |
Thank you for the assistance @rebeccabilbro and @lwgray, I'm happy to contribute! I'll make a PR request shortly, after I've had a chance to make some code changes 🙂 |
@naresh-bachwani -- please see this issue as you work on #930; @rebeccabilbro pointed out in #927 that we might be able to close this as you work through it. |
@naresh-bachwani have we managed to make progress on this? Can we close the issue? |
The following improvements can be made to the manifold visualizer:
Note to contributors: items in the below checklist don't need to be completed in a single PR; if you see one that catches your eye, feel to pick it off the list!
frameon=True
to legendtest_manifold_pandas
(not sure why the tolerance is so high)n_neighbors
attribute; see below.See #398 #399
The text was updated successfully, but these errors were encountered: