Fixes part of #437

[jimmyshah]

Adds frameon=true from #437 , I closed the previous PR

[jimmyshah]

I think I'm having some trouble understanding the problem with my submission. Would it be possible to receive some feedback?

[rebeccabilbro]

Hey there @jimmyshah and thanks for checking out Yellowbrick and for helping us work through our (ever growing 😅) backlog of issues!

Here's what's happening with your PR; you've globally modified the manual_legend utility, which is used by many of our visualizers. As a result, your change has broken many of those existing visualizers (for instance, ParallelCoordinates, which already passes in a frameon argument).

The request in #437 is to do something similar with Manifold as is currently done in ParallelCoordinates (e.g. passing the frameon kwarg into the call to manual_legend, which already knows how to consume any **legend_kwargs that get passed in), not to modify the manual_legend utility function directly.

Note that when you make this change, it should fix all the CI errors, but we may need to work through some new broken image tests for Manifold — if you want to get a jump on figuring those out, you can read up on our visual image tests here and here!

Apologies for the confusion, and hope this is helpful!

[jimmyshah]

Thank you so much for the elaborate response @rebeccabilbro ! It was really helpful and I understand the issue more clearly now. I'm going to try working on this again in a bit.

[jimmyshah]

@rebeccabilbro Thank you again for your all of your help! It looks like my commit is passing the Travis CI check according to the site, but it is still showing it as being queued here. Is there something else that I need to do?

[rebeccabilbro]

Looks great @jimmyshah — all the tests are passing now, so I'll go ahead and merge this in. We hope to see future contributions from you!

One tiny request is that for your next contribution, you use a feature branch (you can read more about our branching conventions here) instead of merging from your develop branch; it makes reviewing easier on us maintainers and ensures your develop stays well-groomed! Thanks again for checking out Yellowbrick and hope to see you around!

[jimmyshah]

@rebeccabilbro This is so wonderful to hear! Thank you so much, and I look forward to future contributions. I can use the feature branch convention going forward as well, my apologies about that.