-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Explained Variance #1037
base: develop
Are you sure you want to change the base?
[WIP] Explained Variance #1037
Conversation
…owbrick into naresh-bachwani-decomposition
@naresh-bachwani prototype version: |
Hey there @bbengfort,
|
Questions: Is 85% variance some kind of magical number similar to p=0.05, or "rule of thumb" correlation coefficients or effect size? Below is an example on some of the expected magic numbers in "rule of thumb" tables:
Reference: https://archive.fo/Bi6yF https://archive.fo/ourlZ https://archive.fo/hVKdt https://archive.fo/jQOX8 https://archive.fo/Xh9xk |
@BrandonKMLee - yes, exactly right, it's just a rule of thumb about how many components are needed to have a "very strong" correlation or "enough explained variance" similar to the table you provided or a p value of 0.05. |
@bbengfort Thanks for the issue mention. Looking at the above plot (which is pretty good) I would mention a few things.
|
Some alternative ideas:
|
This PR fixes #316 and extends #954 to get it wrapped up.
I have made the following changes:
Sample Code and Plot
If you are adding or modifying a visualizer, PLEASE include a sample plot here along with the code you used to generate it.
TODOs and questions
Still to do:
CHECKLIST
pytest
?make html
?