Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses Issue #615 : Adding new parameters "Colorbar" and "Heatmap" in PCA visualizer #792

Closed
wants to merge 5 commits into from

Conversation

percygautam
Copy link
Contributor

The following changes were made to pca.py referenced in #615 :

  1. Added new optional parameters 'Colorbar' and 'Heatmap' which shows the magnitude of each feature value to the component, for both '2D' and '3D' cases.

Next Step:

  1. Updating Documentation with a proper explanation on how to use these two optional parameters when using PCA visualizer.

P.S: I am adding a snippet showing PCA visualization of the dataset 'credit' from yellowbrick.datasets, when both the parameters are True and proj_dim = 2.
Test_figure

@lwgray
Copy link
Contributor

lwgray commented Mar 24, 2019

@percygautam Thanks for the wonderful PR. We are just coming off a hiatus and it might take a bit to get to this but we will asap.

@percygautam
Copy link
Contributor Author

Sure, no problem.

@percygautam
Copy link
Contributor Author

@lwgray I noticed that I have not made this PR from feature branch as you have asked in other PRs. Should I close this one and create another one from feature branch?

@lwgray
Copy link
Contributor

lwgray commented Apr 11, 2019

@percygautam That would be great if you could create another one from a feature branch.

@bbengfort bbengfort removed the ready label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants