Final Tweaks #946
Merged
Final Tweaks #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbengfort
reviewed
Aug 14, 2019
| @@ -589,10 +599,11 @@ def pca_decomposition( | |||
| # Fit and transform the visualizer (calls draw) | |||
| visualizer.fit(X, y) | |||
| visualizer.transform(X, y) | |||
| visualizer.poof() | |||
| visualizer.finalize() | |||
There was a problem hiding this comment.
This fixes a test warning about the agg backend.
bbengfort
reviewed
Aug 14, 2019
tests/test_features/test_pca.py
Outdated
| @@ -120,7 +120,7 @@ def test_discrete(self): | |||
| """ | |||
| Test discrete target. | |||
| """ | |||
| colors = ["Y", "C0"] | |||
| colors = ["y", "C0"] | |||
There was a problem hiding this comment.
This was issuing a deprecation warning that upper case single letter colors are no longer allowed.
bbengfort
reviewed
Aug 14, 2019
| def test_manifold_no_transform(self): | ||
| """ | ||
| Test the exception when manifold doesn't implement transform. | ||
| """ | ||
| X, _ = make_s_curve(1000, random_state=888) | ||
| manifold = Manifold(manifold="lle", target="auto") | ||
| manifold = Manifold(manifold="lle", n_neighbors=5, target="auto") |
bbengfort
reviewed
Aug 14, 2019
| manifold = Manifold(manifold="lle", target="auto", projection=projection) | ||
| manifold = Manifold( | ||
| manifold="lle", target="auto", n_neighbors=5, projection=projection | ||
| ) |
bbengfort
reviewed
Aug 14, 2019
| ) | ||
| def test_manifold_algorithm_transform_fit(self, algorithm): | ||
| """ | ||
| Test manifold fit with algorithms having transform implemented | ||
| """ | ||
| X, y = make_s_curve(1000, random_state=94) | ||
| manifold = Manifold(manifold=algorithm, target="auto") | ||
| with pytest.warns(YellowbrickWarning): | ||
| manifold = Manifold(manifold=algorithm, target="auto") |
bbengfort
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
@naresh-bachwani thank you so much for making these final tweaks to the projection classes; you've definitely enhanced the style and interpretability of these plots with just a few simple changes. I'll take care of fixing the tests this morning and we'll get it merged in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #874. It adds final and minor changes to the plots.
I have made the following changes: