CADENZA-37531 and CADENZA-38242: #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
klschm
commented
Nov 19, 2024
klschm
commented
- Cleanup of type definition 'LayerDefinition'
- Fix displaying of parameter descriptions in case of an options object being destructured immediately (in this case the parameter descriptions weren't visible in the documentation)
- Order the parameters in alphabetical order
- Add the Cadenza JS part for zooming extensions
- Cleanup of type definition 'LayerDefinition' - Fix displaying of parameter descriptions in case of an options object being destructured immediately (in this case the parameter descriptions weren't visible in the documentation) - Order the parameters in alphabetical order - Add the Cadenza JS part for zooming extensions
* CADENZA-37667 fix: update version in package-lock.json * CADENZA-37667 doc: typo * CADENZA-37667 doc: update docs * CADENZA-37667 doc: introduce Feature property: circumference, which was missing * CADENZA-37667 doc: adjusted CHANGELOG.md * CADENZA-37667 doc: better typing for Coordinate type * CADENZA-37667 doc: fix indent
…ext dev version (#64)
…bumps in release workflow
… download reports generated from report template embedding targets as PDF
- Fix CadenzaClientOptions to use options again instead of __namedParameter
- Ran prettier now - Added Changelog entries
- Remove duplicated Changelog entry
- Add overriding of locationFinder by mapExtent also explicitely in the code like it was before the story CADENZA-37531
- Fix handling useMapSrs parameter for creating a valid GeometryZoomTarget
- Change Sandbox to be usable with all supported ZoomTargets
- Add the zoomTarget also to the "createGeometry" action
jkissel
requested changes
Nov 21, 2024
- Remove the DefaultZoomTarget and the DataExtentZoomTarget - Add the description of the DefaultZoomTarget to the ZoomTarget type - Add the functionality of DataExtentZoomTarget to the LayerDataExtentZoomTarget in case of having no "layers" specified - Rename the MapExtentZoomTarget to StaticZoomTarget - Add the deprecation hint also to the description of the CadenzaClient - Don't let it be possible to have a different "useMapSrs" parameter in the GeometryZoomTarget - Rewrite the description of the "useMapSrs" parameter to make it clear it applies to all given coordinates - Rename the function "createValidZoomTarget" to "sanitizeZoomTarget" and make it much simpler - Remove 'locationFinder' and 'mapExtent' parameters from the 'createParams' method, because they were already considered correctly in the "sanitizeZoomTarget" method - Simplify the method when to send the 'setZoomTarget' postMessage and when to not do it - Add the "zoomTarget" parameter also to the "selectObjects" method to apply the extent and locationFinder parameters also correctly there - Adapt the Sandbox to the reduced types of ZoomTargets and add the parameter also to the selectObjects command
jkissel
approved these changes
Nov 22, 2024
jkissel
reviewed
Nov 22, 2024
sandbox.html
Outdated
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <html lang="en" xmlns="http://www.w3.org/1999/html"> | |||
jkissel
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.