CADENZA-37531 and CADENZA-38242: #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
klschm
commented
Nov 25, 2024
klschm
commented
- Renaming of zoomTarget to extentStrategy
- Define additionalLayers only once in the sandbox and reuse it everywhere needed
added 2 commits
November 25, 2024 10:16
- Renaming of zoomTarget to extentStrategy - Define additionalLayers only once in the sandbox and reuse it everywhere needed
- Reformat examples for extentStrategy in the sandbox to make copying easier
jkissel
approved these changes
Nov 25, 2024
CHANGELOG.md
Outdated
| - `LayerDataExtentZoomTarget`, `LocationFinderZoomTarget` and `StaticZoomTarget` added | ||
| - Added the 'ZoomTarget' also to the sandbox | ||
| - Added `LayerDataExtentStrategy`, `LocationFinderExtentStrategy` and `StaticExtentStrategy` | ||
| - Added the 'Extent Strategy' also to the sandbox |
There was a problem hiding this comment.
The "Added" is redundant with the heading. Proposal:
- `LayerDataExtentStrategy`, `LocationFinderExtentStrategy` and `StaticExtendStrategy`
- "Extent Strategy" in the sandbox
- Remove "Added" phrase from the "Added" section topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.